Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38704 )
Change subject: soc/intel/tigerlake: Update PMC Register Base and platform check for JSP
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38704/2/src/soc/intel/tigerlake/esp...
File src/soc/intel/tigerlake/espi.c:
https://review.coreboot.org/c/coreboot/+/38704/2/src/soc/intel/tigerlake/esp...
PS2, Line 86: 0x4d
Why was 0x38 removed? I see at least on JSL ESPI ID which is 0x3887 here: https://review.coreboot. […]
We need to update the JSL device id's into pch_ids.h, here is the crosbug https://partnerissuetracker.corp.google.com/issues/149185282 to track on it.
Since there are too many devices for comparison, we are using hi_byte for this purpose.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38704
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6017a9703764b5454e7be479c1e08afe614908f1
Gerrit-Change-Number: 38704
Gerrit-PatchSet: 2
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 10 Feb 2020 12:34:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment