Attention is currently required from: Subrata Banik, Himanshu Sahdev.
Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74577 )
Change subject: soc/intel/cse_lite: Back up PSR data during CSE FW downgrade
......................................................................
Patch Set 28:
(2 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74577/comment/b4a7d01c_accfe2c0
PS27, Line 150: .
.header.length = sizeof(header); […]
here the length field is the total length excluding the size of header. So it is left at default value 0
https://review.coreboot.org/c/coreboot/+/74577/comment/88810cc6_b83fb92f
PS27, Line 156: 0x4
What this cse_addr signifies? […]
updated new patchset . pls see comments
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74577
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I135d197b5df0a20def823fe615860b5ead4391f8
Gerrit-Change-Number: 74577
Gerrit-PatchSet: 28
Gerrit-Owner: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.corp-partner.google.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-CC: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-Comment-Date: Tue, 02 May 2023 17:42:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Himanshu Sahdev
himanshu.sahdev@intel.com
Gerrit-MessageType: comment