Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56070 )
Change subject: util/ifdtool: Add sklkbl to IFDv2 platforms ......................................................................
util/ifdtool: Add sklkbl to IFDv2 platforms
Currently ifdtool breaks the descriptor because it treats it as IFDv1. This change adds it to the list of IFDv2 platforms. Fixes boot for X11SSH-LN4F.
Fixes: 8c082e5fef ("util/ifdtool: Use -p platform name to detect IFDv2 platform and chipset") Change-Id: I3f92b090e929336b5c18b442d1504ee1000f5594 Signed-off-by: Jan Tatje jan@jnt.io Reviewed-on: https://review.coreboot.org/c/coreboot/+/56070 Reviewed-by: Subrata Banik subrata.banik@intel.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/ifdtool/ifdtool.c 1 file changed, 4 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index e99cdec..b91c90c 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -205,9 +205,8 @@ return CHIPSET_9_SERIES_WILDCAT_POINT; } else if (nm == 6) { return CHIPSET_C620_SERIES_LEWISBURG; - } else { - return CHIPSET_100_200_SERIES_SUNRISE_POINT; } + return CHIPSET_PCH_UNKNOWN; }
static enum ich_chipset ifd2_platform_to_chipset(const int pindex) @@ -219,6 +218,8 @@ return CHIPSET_N_SERIES_JASPER_LAKE; case PLATFORM_EHL: return CHIPSET_x6000_SERIES_ELKHART_LAKE; + case PLATFORM_SKLKBL: + return CHIPSET_100_200_SERIES_SUNRISE_POINT; case PLATFORM_CNL: return CHIPSET_300_SERIES_CANNON_POINT; case PLATFORM_TGL: @@ -250,6 +251,7 @@ PLATFORM_JSL, PLATFORM_EHL, PLATFORM_ADL, + PLATFORM_SKLKBL, }; unsigned int i;