Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38006 )
Change subject: usbdebug: Fix printk conversion ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38006/1/src/drivers/usb/ehci_debug.... File src/drivers/usb/ehci_debug.c:
https://review.coreboot.org/c/coreboot/+/38006/1/src/drivers/usb/ehci_debug.... PS1, Line 455: dprintk(BIOS_INFO, "ehci_bar: 0x%zx debug_offset 0x%x\n", ehci_bar, offset); Uint pointers are not directly related with size_t. Would prefer `lx` instead (we noticed that for all supported platforms `long` matches pointers in size when writing generic stdint.h/inttypes.h) or just use PRIxPTR which can't be bikeshedded.