Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87064?usp=email )
Change subject: mb/google/fatcat: Conditionally check for barrel charger ......................................................................
mb/google/fatcat: Conditionally check for barrel charger
The barrel charger check in `baseboard_devtree_update` was unconditional, increasing boot time on platforms without it.
This commit conditions the check on `CONFIG(BOARD_GOOGLE_MODEL_FATCAT)`, making it specific to the fatcat board.
This avoids unnecessary delay on platforms like francka and felino.
BUG=b:328770565 TEST=Boot time reduced by 56ms.
Change-Id: Id7a26b634a1a310f714fbf4b4a2accd75665bc28 Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/87064 Reviewed-by: Kapil Porwal kapilporwal@google.com Reviewed-by: Pranava Y N pranavayn@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jayvik Desai jayvik@google.com --- M src/mainboard/google/fatcat/variants/baseboard/fatcat/ramstage.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Pranava Y N: Looks good to me, approved Kapil Porwal: Looks good to me, approved Jayvik Desai: Looks good to me, approved
diff --git a/src/mainboard/google/fatcat/variants/baseboard/fatcat/ramstage.c b/src/mainboard/google/fatcat/variants/baseboard/fatcat/ramstage.c index 030b587..21f8ccd 100644 --- a/src/mainboard/google/fatcat/variants/baseboard/fatcat/ramstage.c +++ b/src/mainboard/google/fatcat/variants/baseboard/fatcat/ramstage.c @@ -53,7 +53,7 @@ void baseboard_devtree_update(void) { /* Don't optimize the power limit if booting with barrel attached */ - if (google_chromeec_is_barrel_charger_present()) + if (CONFIG(BOARD_GOOGLE_MODEL_FATCAT) && google_chromeec_is_barrel_charger_present()) return;
if (!google_chromeec_is_battery_present())