24 Nov
2020
24 Nov
'20
12:58 p.m.
Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47907 )
Change subject: WIP]: SPI, DMI changes to support extended BIOS region ......................................................................
Patch Set 7:
@Furquan, Added the initial changes, this is just a place holder CL. If you check it once I can update the relation chain. I didnt want to mess up the chain hence pushed it as WIP here. I had some questions on couple of things, 1. During GPMR programming in dmi.c I think I am missing the check PCR base address being configured. 2. The MTRR programming can be better in terms of reusing the same code block. Also I will split this into 3 CLs as per the document.
--
To view, visit https://review.coreboot.org/c/coreboot/+/47907
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17b0f8a21b757946168c8660aef2852c96165378
Gerrit-Change-Number: 47907
Gerrit-PatchSet: 7
Gerrit-Owner: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 24 Nov 2020 11:58:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment