Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38252 )
Change subject: cpu/x86/entry16: Do not disable cache when Boot Guard is supported
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38252/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38252/7//COMMIT_MSG@10
PS7, Line 10: BIOS is forbidden to disable
: cache while in NEM mode with BtG enabled.
Can you please add a reference to the specification?
This kind of stuff is only documented in the `Boot Guard BIOS Writer's Guide`. As usual with BWGs, it's Intel Confidential.
In any case, feel free to add:
As per the Boot Guard BWG, BIOS is forbidden to disable cache while in NEM mode with BtG enabled.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38252
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1def754f7b0024725638fcea481fd3273ef3d24
Gerrit-Change-Number: 38252
Gerrit-PatchSet: 7
Gerrit-Owner: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 13 Jul 2020 11:30:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment