Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34386 )
Change subject: util/lint/checkpatch.pl: Update line length to 96
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34386/1/util/lint/checkpatch.pl
File util/lint/checkpatch.pl:
https://review.coreboot.org/c/coreboot/+/34386/1/util/lint/checkpatch.pl@54
PS1, Line 54: my $max_line_length = 96;
Updating my pre-commit-hook solves the issue. So sorry for the noise. […]
We changed the pre-commit hook last year to just call lint-007 instead of calling checkpatch by hand, so that issue should resolve itself over time.
More generally speaking, we don't want to change automatically running scripts to change without notice (otherwise we could probably just add a symlink to util/gitconfig/pre-commit to .git/hooks), and I'm not quite sure where we should put any kind of warning that the script was updated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34386
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f34c93c2af4a7f1928af28320ef2abd66dac0bb
Gerrit-Change-Number: 34386
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jul 2019 14:03:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment