Attention is currently required from: Bill XIE.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48771 )
Change subject: mainboard/lenovo: Add Thinkpad Edge S220 (a.k.a E220s)
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/lenovo/s220/early_init.c:
https://review.coreboot.org/c/coreboot/+/48771/comment/bff378e7_6439955d
PS2, Line 42: CONFIG_EC_BASE_ADDRESS | 1);
How could I reserve memory ranges?
For LGMR, do something similar to CB:51717 on bd82x6x. Add the LGMR code next to the existing code for GENx_DEC registers.
https://review.coreboot.org/c/coreboot/+/48771/comment/2aa5b132_ad69f7a2
PS2, Line 50: FIXME
Hm?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48771
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I746798b13e83d1971bb7be93751a15875d16c337
Gerrit-Change-Number: 48771
Gerrit-PatchSet: 3
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bill XIE
persmule@hardenedlinux.org
Gerrit-Comment-Date: Wed, 14 Apr 2021 16:35:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bill XIE
persmule@hardenedlinux.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment