Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37228 )
Change subject: vc/amd/pi: Allow 00670F00 to build with no binaryPI ......................................................................
Patch Set 1: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/37228/1/src/vendorcode/amd/pi/00670... File src/vendorcode/amd/pi/00670F00/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37228/1/src/vendorcode/amd/pi/00670... PS1, Line 122: unlikely
From my understanding... […]
Not sure if maybe Arthur wanted to replace unlikely with impossible... I do understand as I saw the message coming out in one of my builds. I would agree with Arthur, the word impossible would be better as it won't come out of reset. However I'm not sure I agree with the message as a whole, as if it was only AGESA it would hang at boot init early, but with PSP it will not even come out of reset. Why not replace AGESA with "AMD binaries", as it's not specific and actually indicate all: PSP, video and AGESA. Than do replace unlikely with impossible.