[coreboot-gerrit] [M] Change in coreboot[master]: ec/google/chromeec: Split wait-loop for DP and HPD flags

[Kapil Porwal (Code Review)]

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Subrata Banik, Tarun Tuli.

Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76370?usp=email )

Change subject: ec/google/chromeec: Split wait-loop for DP and HPD flags
......................................................................

Patch Set 2:

(3 comments)

File src/ec/google/chromeec/ec.c:

https://review.coreboot.org/c/coreboot/+/76370/comment/be507a71_47b08b08 :
PS1, Line 1394: 	if (!google_chromeec_check_feature(EC_FEATURE_TYPEC_REQUIRE_AP_MODE_ENTRY)) {
              : 		google_chromeec_usb_get_pd_mux_info(port, &mux_flags);
              : 		printk(BIOS_INFO, "mux_flags = 0x%x\n", mux_flags);
              : 		if (!(mux_flags & USB_PD_MUX_DP_ENABLED)) {
              : 			printk(BIOS_WARNING, "DP mode entry is not ready. Abort.\n");
              : 			return -1;
              : 		}
              : 
              : 		return 0;
              : 	}
> worth of a helper function taking one argument as in bit to check ?

Acknowledged

https://review.coreboot.org/c/coreboot/+/76370/comment/915b89c0_302cda37 :
PS1, Line 1408: 	printk(BIOS_INFO, "mux_flags = 0x%x\n", mux_flags);
> don't need

Acknowledged

https://review.coreboot.org/c/coreboot/+/76370/comment/d64be6ba_88a34c47 :
PS1, Line 1427: 		printk(BIOS_INFO, "mux_flags = 0x%x\n", mux_flags);
> don't need

Acknowledged