Attention is currently required from: Martin L Roth, Maximilian Brune, Philipp Hug, ron minnich.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81124?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: arch/riscv: Remove typedefs
......................................................................
Patch Set 1:
(1 comment)
File src/arch/riscv/include/mcall.h:
https://review.coreboot.org/c/coreboot/+/81124/comment/487b3a27_dd40582f :
PS1, Line 64: #define OTHER_HLS(id) ((struct hls*)((void*)HLS() + RISCV_PGSIZE * ((id) - HLS()->hart_id)))
`"(foo*)" should be "(foo *)"`
While on it, please fix these spacing issues.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81124?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id51eda53b6b53ed2cc66c0339c03c855c12c1bd8
Gerrit-Change-Number: 81124
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Thu, 07 Mar 2024 22:21:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment