Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35409 )
Change subject: [WIP]arch/arm: Allow program loading of Linux kernels ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35409/2/src/arch/arm/boot.c File src/arch/arm/boot.c:
https://review.coreboot.org/c/coreboot/+/35409/2/src/arch/arm/boot.c@26 PS2, Line 26: case CBFS_TYPE_FIT: /* Flattened image tree */ You also need a dcache_mmu_disable() here, and an "msr cpsr_cxf, #0xd3" in assembly (to switch from System into SVC mode). (May also want to copy the warning about how this makes the stack pointer invalid from depthcharge: https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/refs/hea... )
https://review.coreboot.org/c/coreboot/+/35409/2/src/arch/arm/boot.c@27 PS2, Line 27: if (CONFIG(PAYLOAD_FIT_SUPPORT)) { I'm not sure 3 instructions need to be compile-time guarded for space...
https://review.coreboot.org/c/coreboot/+/35409/2/src/arch/arm/boot.c@33 PS2, Line 33: : [fdt_ptr] "r" (prog_entry_arg(prog))); I think implementing this as an extra function in armv7/cpu.S would be cleaner than inline assembly.