HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45316 )
Change subject: src: Add missing <device/pnp_def.h>
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45316/1/src/include/device/pnp.h
File src/include/device/pnp.h:
https://review.coreboot.org/c/coreboot/+/45316/1/src/include/device/pnp.h@a6
PS1, Line 6: #include <device/pnp_def.h>
I'm not really sure if removing this here is a good idea or not. […]
I like the idea to include indirectly <device/pnp_def.h> using <device/pnp.h> , but only when <device/pnp.h> is needed.
I mean, including <device/pnp.h> just for "PNP_IDX_*" isn't reasonable.
I'll update current patch and remove redundant <device/pnp_def.h> when <device/pnp.h> is needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45316
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9903ae456c32db4ba346020659c17c27a939e89
Gerrit-Change-Number: 45316
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Sep 2020 05:44:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment