Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45939 )
Change subject: fw_config: Convert fw_config to a 64-bit field
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45939/1/src/ec/google/chromeec/ec.c
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/45939/1/src/ec/google/chromeec/ec.c...
PS1, Line 854: return -1
Isn't this going to break getting the fw_config on all existing platforms that don't have the SSFC field?
Maybe add a Kconfig option to control this?
uint32_t ssfc = 0;
if (cbi_get_uint32(&ssfc, CBI_TAG_SSFC) && !CONFIG(FW_CONFIG_32_BITS))
return -1;
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45939
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f2065d347eafa0ef7b346caeabdc3b626402092
Gerrit-Change-Number: 45939
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 01 Oct 2020 22:32:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment