Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37791 )
Change subject: {drivers,soc}/intel/fsp1_1: Move chipset specific logo handling to SoC
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37791/4/src/drivers/intel/fsp1_1/ra...
File src/drivers/intel/fsp1_1/ramstage.c:
https://review.coreboot.org/c/coreboot/+/37791/4/src/drivers/intel/fsp1_1/ra...
PS4, Line 217: }
In this case 124 to 126 and 129 should be removed as well.
Right... and I just realized that we can theoretically drop all the weak
functions (if we assume that there won't be any new platforms with FSP1.1).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37791
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86943e64ca1ddd05e7e88fc6b882cfd33b98272e
Gerrit-Change-Number: 37791
Gerrit-PatchSet: 4
Gerrit-Owner: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 02 Jan 2020 16:11:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wim Vervoorn
wvervoorn@eltan.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment