Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42095 )
Change subject: sc7180: Remove QcLib specific changes from CB UART
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42095/1/src/soc/qualcomm/sc7180/qup...
File src/soc/qualcomm/sc7180/qupv3_config.c:
https://review.coreboot.org/c/coreboot/+/42095/1/src/soc/qualcomm/sc7180/qup...
PS1, Line 55: if (protocol != SE_PROTOCOL_UART) {
UART does not use DFSR mode, it is only SPI and I2C which uses the DFSR.
That wasn't really the question... eh, whatever, it doesn't really matter as long as it works.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42095
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2531b64eddfa6e877f769af0d17be61f5e4d0c35
Gerrit-Change-Number: 42095
Gerrit-PatchSet: 8
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Roja Rani Yarubandi
c_rojay@qualcomm.corp-partner.google.com
Gerrit-CC: Taniya Das
tdas@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Mon, 06 Jul 2020 23:53:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Roja Rani Yarubandi
c_rojay@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Taniya Das
tdas@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment