Attention is currently required from: Sean Rhodes.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74331 )
Change subject: device: Change NO_S0IX_SUPPORT default to def_bool ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
starlabs/starbook has `select NO_S0IX_SUPPORT`. […]
It works for me with the parent of this change checked out. Just like I would expect. ``` [icon@bob coreboot]$ git describe --dirty 4.19-1152-g20dcfcb05eca [icon@bob coreboot]$ make clean [icon@bob coreboot]$ echo CONFIG_VENDOR_STARLABS=y >.config [icon@bob coreboot]$ echo CONFIG_BOARD_STARLABS_STARBOOK_ADL=y >>.config [icon@bob coreboot]$ make olddefconfig # # configuration written to /home/icon/coreboot/.config # [icon@bob coreboot]$ grep NO_S0IX .config CONFIG_NO_S0IX_SUPPORT=y ```
If I look into menuconfig, I see it selected and can't change it.