[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/common: Introduce API to get the FSP Reset Status

[Subrata Banik (Code Review)]

Attention is currently required from: Tarun Tuli, Derek Huang, Kapil Porwal, Arthur Heymans.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74783 )

Change subject: soc/intel/common: Introduce API to get the FSP Reset Status
......................................................................

Patch Set 1:

(1 comment)

File src/soc/intel/common/fsp_reset.c:

https://review.coreboot.org/c/coreboot/+/74783/comment/53519e0b_8c58af4a 
PS1, Line 54: if (!CONFIG(FSP_MULTIPHASE_SI_INIT_RETURN_BROKEN))
            : 		return 0;
> > > In the next patch the caller also checks this.
> >
> > yeah, i just wanted to make sure, no one directly calls into it outside the silicon_init.c file.
> >
> > WDYT?
>
> I think you can do assert(CONFIG(FSP_MULTIPHASE_SI_INIT_RETURN_BROKEN)); which would result in buildtime failure if used without Kconfig. Does that make sense?

thanks for the suggestion.