[coreboot-gerrit] Change in coreboot[master]: mb/google/daisy: Move 'PMIC_BUS' to Kconfig

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37580 )

Change subject: mb/google/daisy: Move 'PMIC_BUS' to Kconfig
......................................................................

mb/google/daisy: Move 'PMIC_BUS' to Kconfig

Change-Id: If40fa38e5b249452a6dacf4a4045b6bd00c27cfa
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/google/daisy/Kconfig
M src/mainboard/google/daisy/romstage.c
2 files changed, 14 insertions(+), 12 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/37580/1

diff --git a/src/mainboard/google/daisy/Kconfig b/src/mainboard/google/daisy/Kconfig
index f15bd9b..61bb80b 100644
--- a/src/mainboard/google/daisy/Kconfig
+++ b/src/mainboard/google/daisy/Kconfig
@@ -58,4 +58,8 @@
    int
    default 3

+config PMIC_BUS
+	int
+	default 0
+
 endif # BOARD_GOOGLE_DAISY
diff --git a/src/mainboard/google/daisy/romstage.c b/src/mainboard/google/daisy/romstage.c
index 838a6c7..0857024 100644
--- a/src/mainboard/google/daisy/romstage.c
+++ b/src/mainboard/google/daisy/romstage.c
@@ -36,8 +36,6 @@

#include "exynos5250.h"

-#define PMIC_BUS	0
-
 static void setup_power(int is_resume)
 {
    int error = 0;
@@ -63,26 +61,26 @@
     *
     * Disable Coin BATT Charging
     */
-	error = max77686_disable_backup_batt(PMIC_BUS);
+	error = max77686_disable_backup_batt(CONFIG_PMIC_BUS);

-	error |= max77686_volsetting(PMIC_BUS, PMIC_BUCK2, VDD_ARM_MV,
+	error |= max77686_volsetting(CONFIG_PMIC_BUS, PMIC_BUCK2, VDD_ARM_MV,
    					REG_ENABLE, MAX77686_MV);
-	error |= max77686_volsetting(PMIC_BUS, PMIC_BUCK3, VDD_INT_UV,
+	error |= max77686_volsetting(CONFIG_PMIC_BUS, PMIC_BUCK3, VDD_INT_UV,
    					REG_ENABLE, MAX77686_UV);
-	error |= max77686_volsetting(PMIC_BUS, PMIC_BUCK1, VDD_MIF_MV,
+	error |= max77686_volsetting(CONFIG_PMIC_BUS, PMIC_BUCK1, VDD_MIF_MV,
    					REG_ENABLE, MAX77686_MV);
-	error |= max77686_volsetting(PMIC_BUS, PMIC_BUCK4, VDD_G3D_MV,
+	error |= max77686_volsetting(CONFIG_PMIC_BUS, PMIC_BUCK4, VDD_G3D_MV,
    					REG_ENABLE, MAX77686_MV);
-	error |= max77686_volsetting(PMIC_BUS, PMIC_LDO2, VDD_LDO2_MV,
+	error |= max77686_volsetting(CONFIG_PMIC_BUS, PMIC_LDO2, VDD_LDO2_MV,
    					REG_ENABLE, MAX77686_MV);
-	error |= max77686_volsetting(PMIC_BUS, PMIC_LDO3, VDD_LDO3_MV,
+	error |= max77686_volsetting(CONFIG_PMIC_BUS, PMIC_LDO3, VDD_LDO3_MV,
    					REG_ENABLE, MAX77686_MV);
-	error |= max77686_volsetting(PMIC_BUS, PMIC_LDO5, VDD_LDO5_MV,
+	error |= max77686_volsetting(CONFIG_PMIC_BUS, PMIC_LDO5, VDD_LDO5_MV,
    					REG_ENABLE, MAX77686_MV);
-	error |= max77686_volsetting(PMIC_BUS, PMIC_LDO10, VDD_LDO10_MV,
+	error |= max77686_volsetting(CONFIG_PMIC_BUS, PMIC_LDO10, VDD_LDO10_MV,
    					REG_ENABLE, MAX77686_MV);

-	error |= max77686_enable_32khz_cp(PMIC_BUS);
+	error |= max77686_enable_32khz_cp(CONFIG_PMIC_BUS);

if (error) {
    	printk(BIOS_CRIT, "%s: PMIC error: %#x\n", __func__, error);