Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40623 )
Change subject: Revert "soc/mediatek/mt8183: Force retraining memory if requested"
......................................................................
Patch Set 2:
Hi Julius, I think VB2_RECOVERY_TRAIN_AND_REBOOT is needed. It is the equivalent command to 'crossystem recovery_request=0xc4', which we used in factory process to enforce DRAM training ( https://chromium.googlesource.com/chromiumos/platform/factory/+/HEAD/py/test... ), for both x86 and ARM.
Without this, we can't enforce re-training in manufacturing process.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40623
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5df5e00526e90cb573131de3c8bac9f85f4e3a5f
Gerrit-Change-Number: 40623
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 23 Apr 2020 01:40:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment