Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46504 )
Change subject: soc/intel/cannonlake: Fix memory corruptions
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46504/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46504/2//COMMIT_MSG@9
PS2, Line 9: Coverity detects source memory is overrun. Fix this issue by using
The destination array has fixed 24 bytes. […]
Sounds like using CONFIG_MAX_ROOT_PORTS is the correct thing to do, as far as the size goes
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46504
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc253eb9348d959a9e9e69a3f13933b7f97d6ecc
Gerrit-Change-Number: 46504
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 16 Oct 2020 18:47:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment