[coreboot-gerrit] Change in coreboot[master]: security/intel/stm: Add STM support

[Name of user not set (Code Review)]

[e-mail] has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )

Change subject: security/intel/stm: Add STM support
......................................................................

Patch Set 48:

(3 comments)

Will issue a new patch set once I get the smm_segs.h issue resolved

https://review.coreboot.org/c/coreboot/+/33234/48/src/cpu/x86/mp_init.c 
File src/cpu/x86/mp_init.c:

https://review.coreboot.org/c/coreboot/+/33234/48/src/cpu/x86/mp_init.c@357 
PS48, Line 357: abiility
> why is a typo being added?

Not sure how this happened, but this has been fixed

https://review.coreboot.org/c/coreboot/+/33234/48/src/cpu/x86/mp_init.c@758 
PS48, Line 758: 		} else
> Code style says that, since the if-branch needs braces, the else-branch should use braces as well: […]

Fixed.  Also, corrected instances in SmmStm.c and StmPlatformSmm.c

https://review.coreboot.org/c/coreboot/+/33234/48/src/cpu/x86/mp_init.c@1040 
PS48, Line 1040: 	// make sure there is enough room for the SMM descriptor
> nit: comment style should be consistent

Done