Marc Jones (marc@marcjonesconsulting.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17148
-gerrit
commit 0c29979e0394af7ed1c9428e0e5f49dfd4145edf Author: Marc Jones marcj303@gmail.com Date: Tue Sep 20 22:55:54 2016 -0600
util/amdfwtool: Increase space used for structures
Double the space for psp2dir to 0x200.
Based on advice from AMD, increase the region containing the signature to 4K.
Original-Signed-off-by: Marc Jones marcj303@gmail.com Original-Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com (cherry picked from commit e03a9402711c3a210816d0aa32865491a0523639)
Change-Id: If60132f913928bab0c2fe4aacedf342080929599 Signed-off-by: Marc Jones marcj303@gmail.com --- util/amdfwtool/amdfwtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index ccddfec..92b8a1b 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -538,7 +538,7 @@ int main(int argc, char **argv) } }
- current = ALIGN(current, 0x100); + current = ALIGN(current, 0x1000); current = integrate_firmwares(rom, current, amd_romsig, amd_fw_table);
if (pspflag == 1) { @@ -555,7 +555,7 @@ int main(int argc, char **argv) current = ALIGN(current, 0x10000); /* PSP2 dir */ psp2dir = rom + current; amd_romsig[5] = current + ROM_BASE_ADDRESS; - current += 0x100; /* Add conservative size of psp2dir. */ + current += 0x200; /* Add conservative size of psp2dir. */
#if PSP_COMBO /* TODO: remove the hardcode. */