Attention is currently required from: Martin Roth, Jamie Ryu, Rizwan Qureshi, Sridhar Siricilla, Krishna P Bhat D, Patrick Rudolph, Karthik Ramasubramanian.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50472 )
Change subject: elog: Support logging CSE Lite info in elog
......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50472/comment/3a08762d_a92cd940
PS6, Line 25: 2 | 2021-01-21 08:46:18 | CSE Info | Lite | 13.50.0.1269 | 13.50.0.1269
: | YES | 0x5 | 0x3 | RO
: 3 | 2021-01-21 08:46:21 | CSE Info | Lite | 13.50.0.1269 | 13.50.0.1269
: | YES | 0x5 | 0x0 | RW
To move logging cse lite info in ramstage would require us to move heci command implementations to c […]
If we move System boot to happen before romstage, I think the timeline would look much better. Something like:
0 | ... | System boot | xxxx
1 | ... | CSE Info | Lite | a.b.c.d | a.b.c.d | YES | 0x5 | 0x3 | RO
2 | ... | System boot | xxxy
3 | ... | CSE Info | Lite | a.b.c.d | a.b.c.d | YES | 0x5 | 0x3 | RW
4 | ...
BTW, I am not sure what "YES" really means. Anyways, since it is related to displaying info only, we can address that in the mosys CL.
https://review.coreboot.org/c/coreboot/+/50472/comment/86132448_d88de8e3
PS6, Line 29: 4 | 2021-01-21 08:46:25 | System boot | 3098
Can we move "System boot" event log to romstage? or can we have the timeline in this order ? […]
Moving system boot to romstage or even bootblock sounds okay to me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50472
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib183941d1fa0a9971e30b4092ea3d23daaa29334
Gerrit-Change-Number: 50472
Gerrit-PatchSet: 6
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 02 Mar 2021 18:05:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-MessageType: comment