[coreboot-gerrit] Change in coreboot[master]: drivers/vpd: add framework to search VPD in romstage

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34634 )

Change subject: drivers/vpd: add framework to search VPD in romstage
......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34634/10/src/drivers/vpd/vpd_premem... 
File src/drivers/vpd/vpd_premem.c:

https://review.coreboot.org/c/coreboot/+/34634/10/src/drivers/vpd/vpd_premem... 
PS10, Line 78: struct vpd_blob *blob = car_get_var_ptr(&g_vpd_blob);
             : 	if (!blob)
             : 		return;
> vpd_load_blob() needs to be called only once during boot time, similar to "RAMSTAGE_CBMEM_INIT_HOOK( […]

yes but I'm not sure why it can't be done automatically inside vpd_get_buffers. In fact, unless if you'd really want to pass same VPD buffer between different pre-ram stages (decompress, bootblock, romstage, verstage), I see no reason why we can't simply declare two static vars for it:

static bool initialized;
 static struct vpd_blob blob;

if (initialized)
     return &blob;

initialized = true;
  vpd_get_blob(&blob);
  return &blob;