[coreboot-gerrit] Change in coreboot[master]: drivers/intel/mipi_camera: Handle acpi_name and common code

[Sugnan Prabhu S (Code Review)]

Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41607 )

Change subject: drivers/intel/mipi_camera: Handle acpi_name and common code
......................................................................

Patch Set 24:

(2 comments)

https://review.coreboot.org/c/coreboot/+/41607/23/src/drivers/intel/mipi_cam... 
File src/drivers/intel/mipi_camera/camera.c:

https://review.coreboot.org/c/coreboot/+/41607/23/src/drivers/intel/mipi_cam... 
PS23, Line 24: 	address = PCI_SLOT(dev->path.pci.devfn) & 0xffff;
             : 	address <<= 16;
             : 	address |= PCI_FUNC(dev->path.pci.devfn) & 0xffff;
             : 	acpigen_write_name_dword("_ADR", address);
> acpigen_write_ADR_pci_device 😊

Done

https://review.coreboot.org/c/coreboot/+/41607/23/src/drivers/intel/mipi_cam... 
PS23, Line 168: 		prefix = "ERR"; /* Error */
              : 		printk(BIOS_ERR, "Invalid device type: %x\n", config->device_type);
              : 		break;
> just my opinion: I don't think setting prefix is necessary here; device_operations. […]

Done