[coreboot-gerrit] Change in coreboot[master]: binaryPI: implement C bootblock

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36914 )

Change subject: binaryPI: implement C bootblock
......................................................................

Patch Set 16:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36914/18/src/northbridge/amd/pi/boo... 
File src/northbridge/amd/pi/bootblock.c:

https://review.coreboot.org/c/coreboot/+/36914/18/src/northbridge/amd/pi/boo... 
PS18, Line 32: 
Copy the stoneyridge comment here? I think it applies too.

/*
     * todo: AGESA currently writes variable MTRRs.  Once that is
     *       corrected, un-hardcode this MTRR.
     *
     *       Be careful not to use get_free_var_mtrr/set_var_mtrr pairs
     *       where all cores execute the path.  Both cores within a compute
     *       unit share MTRRs.  Programming core0 has the appearance of
     *       modifying core1 too.  Using the pair again will create
     *       duplicate copies.
     */