Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41586 )
Change subject: drivers/vpd: add function to find default boolean key value
......................................................................
Patch Set 1:
In comparison to adding a new function, I'd rather have this implemented as a new region enum.
Current VPD_ANY is actually having "RO first then RW", and we may rename that (or create a new one) as VPD_RO_OR_RW, and for your new usage we may call it VPD_RW_OR_RO.
I think that will be much easier for developers to figure out what it is doing than seeing a get_bool_ex.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41586
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I960688d1f6ab199768107ab73b8a7400a3fdf473
Gerrit-Change-Number: 41586
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 21 May 2020 01:46:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment