Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36882 )
Change subject: mb/(ich7): Use 'intel/common/acpi/platform.asl' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36882/1/src/mainboard/apple/macbook... File src/mainboard/apple/macbook21/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/36882/1/src/mainboard/apple/macbook... PS1, Line 43: Scope(_SB) : { : /* This method is placed on the top level, so we can make sure it's the : * first executed _INI method. : */ : Method(_INI, 0) : { : /* The DTS data in NVS is probably not up to date. : * Update temperature values and make sure AP thermal : * interrupts can happen : */ : : // TRAP(71) // TODO : : \GOS() : : /* And the OS workarounds start right after we know what we're : * running: Windows XP SP1 needs to have C-State coordination : * enabled in SMM. : */ : If (LAnd(LEqual(OSYS, 2001), MPEN)) { : // TRAP(61) // TODO : } : : /* SMM power state and C4-on-C3 settings need to be updated */ : // TRAP(43) // TODO : } : } This is not found somewhere else. It's all broken except \GOS() but coreboot barely uses OSYS