HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38053 )
Change subject: soc/intel/broadwell: Drop _HID and _UID ......................................................................
soc/intel/broadwell: Drop _HID and _UID
A device object must contain either a _HID object or an _ADR object, but should not contain both. If the adress is correct, _HID and _UID are not needed.
Change-Id: I46a3acc3a56bdc34079fa7eb256801baa7f778b9 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/broadwell/acpi/serialio.asl 1 file changed, 7 insertions(+), 75 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/38053/1
diff --git a/src/soc/intel/broadwell/acpi/serialio.asl b/src/soc/intel/broadwell/acpi/serialio.asl index 1b44e95..e0245ed 100644 --- a/src/soc/intel/broadwell/acpi/serialio.asl +++ b/src/soc/intel/broadwell/acpi/serialio.asl @@ -156,9 +156,7 @@
Device (SDMA) { - // Serial IO DMA Controller - Name (_HID, "INTL9C60") - Name (_UID, 1) + Name (_DDN, "Serial IO DMA Controller") Name (_ADR, 0x00150000)
// BAR0 is assigned during PCI enumeration and saved into NVS @@ -193,18 +191,7 @@
Device (I2C0) { - // Serial IO I2C0 Controller - Method (_HID) - { - If (\ISWP ()) { - // WildcatPoint - Return ("INT3432") - } - - // LynxPoint-LP - Return ("INT33C2") - } - Name (_UID, 1) + Name (_DDN, "Serial IO I2C0 Controller") Name (_ADR, 0x00150001)
Name (SSCN, Package () { 432, 507, 30 }) @@ -264,18 +251,7 @@
Device (I2C1) { - // Serial IO I2C1 Controller - Method (_HID) - { - If (\ISWP ()) { - // WildcatPoint - Return ("INT3433") - } - - // LynxPoint-LP - Return ("INT33C3") - } - Name (_UID, 1) + Name (_DDN, "Serial IO I2C1 Controller") Name (_ADR, 0x00150002)
Name (SSCN, Package () { 432, 507, 30 }) @@ -335,18 +311,7 @@
Device (SPI0) { - // Serial IO SPI0 Controller - Method (_HID) - { - If (\ISWP ()) { - // WildcatPoint - Return ("INT3430") - } - - // LynxPoint-LP - Return ("INT33C0") - } - Name (_UID, 1) + Name (_DDN, "Serial IO SPI0 Controller") Name (_ADR, 0x00150003)
// BAR0 is assigned during PCI enumeration and saved into NVS @@ -391,18 +356,7 @@
Device (SPI1) { - // Serial IO SPI1 Controller - Method (_HID) - { - If (\ISWP ()) { - // WildcatPoint - Return ("INT3431") - } - - // LynxPoint-LP - Return ("INT33C1") - } - Name (_UID, 1) + Name (_DDN, "Serial IO SPI1 Controller") Name (_ADR, 0x00150004)
// BAR0 is assigned during PCI enumeration and saved into NVS @@ -459,18 +413,7 @@
Device (UAR0) { - // Serial IO UART0 Controller - Method (_HID) - { - If (\ISWP ()) { - // WildcatPoint - Return ("INT3434") - } - - // LynxPoint-LP - Return ("INT33C4") - } - Name (_UID, 1) + Name (_DDN, "Serial IO UART0 Controller") Name (_ADR, 0x00150005)
// BAR0 is assigned during PCI enumeration and saved into NVS @@ -527,18 +470,7 @@
Device (UAR1) { - // Serial IO UART1 Controller - Method (_HID) - { - If (\ISWP ()) { - // WildcatPoint - Return ("INT3435") - } - - // LynxPoint-LP - Return ("INT33C5") - } - Name (_UID, 1) + Name (_DDN, "Serial IO UART1 Controller") Name (_ADR, 0x00150006)
// BAR0 is assigned during PCI enumeration and saved into NVS