build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46575 )
Change subject: WIP: coreboot: Add anx7625 panel driver ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46575/1/src/mainboard/google/asurad... File src/mainboard/google/asurada/panel.h:
https://review.coreboot.org/c/coreboot/+/46575/1/src/mainboard/google/asurad... PS1, Line 32: #define INIT_DCS_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/1/src/mainboard/google/asurad... PS1, Line 37: #define INIT_GENERIC_CMD(...) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/1/src/mainboard/google/asurad... PS1, Line 42: #define INIT_DELAY_CMD(delay) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46575/1/src/mainboard/google/asurad... PS1, Line 51: #define GPIO_MIPIBRDG_PWREN GPIO(DSI_TE) /* 41 */ please, no space before tabs