Xixi Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46393 )
Change subject: soc/mediatek/mt8192: Add dpm loader ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46393/5/src/soc/mediatek/mt8192/dpm... File src/soc/mediatek/mt8192/dpm.c:
https://review.coreboot.org/c/coreboot/+/46393/5/src/soc/mediatek/mt8192/dpm... PS5, Line 18:
Document the return values.
Ack
https://review.coreboot.org/c/coreboot/+/46393/5/src/soc/mediatek/mt8192/dpm... PS5, Line 23: size_t dm_file_size, pm_file_size;
Is the unit bytes? Add it to the variable name?
Yes, unit as bytes.
https://review.coreboot.org/c/coreboot/+/46393/5/src/soc/mediatek/mt8192/dpm... PS5, Line 38: printk(BIOS_INFO, "dm_file_size:%d, pm_file_size:%d\n",
Does the blob contain a version? Please print it out too.
The blob doesn't contain a version.
https://review.coreboot.org/c/coreboot/+/46393/5/src/soc/mediatek/mt8192/dpm... PS5, Line 38: dm_file_size:%d, pm_file_size:%d
Please add a space after the colon and the units.
Ack