4 comments:
File src/soc/mediatek/mt8192/dpm.c:
Document the return values.
Ack
Patch Set #5, Line 23: size_t dm_file_size, pm_file_size;
Is the unit bytes? Add it to the variable name?
Yes, unit as bytes.
Patch Set #5, Line 38: printk(BIOS_INFO, "dm_file_size:%d, pm_file_size:%d\n",
Does the blob contain a version? Please print it out too.
The blob doesn't contain a version.
Patch Set #5, Line 38: dm_file_size:%d, pm_file_size:%d
Please add a space after the colon and the units.
Ack
To view, visit change 46393. To unsubscribe, or for help writing mail filters, visit settings.