Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40904 )
Change subject: soc/intel/{jsl,tgl}: Rename PcdDebugInterfaceFlags macros for better understanding ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40904/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40904/1//COMMIT_MSG@9 PS1, Line 9: DEBUG_INTERFACE_ISA_SERIAL What does "ISA serial" mean in this context? I thought ISA was no longer a thing in computers from the last two decades (well, LPC is related to ISA).
I see that we use `DRIVERS_UART_8250IO` as a condition to choose between these two options. Is this because `DEBUG_INTERFACE_ISA_SERIAL` uses IO ports (e.g. 0x3f8), and `DEBUG_INTERFACE_LPSS_SERIAL_IO` is a memory-mapped device?
If so, should we refer to `ISA_SERIAL` as `DEBUG_INTERFACE_UART_8250IO` instead?