Ryback Hung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40334 )
Change subject: configs: Add builder config to create a working Sonora Pass ......................................................................
Patch Set 3:
(3 comments)
Already followed comment to modify accordingly.
https://review.coreboot.org/c/coreboot/+/40334/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40334/2//COMMIT_MSG@7 PS2, Line 7: configs/builder/config.ocp.sonorapass: Config for SonoraPass PO. : src/mainboard/ocp/sonorapass/*.*: Preliminary platform porting for SonoraPass PO.
You should split it into 2 different patches […]
Done
https://review.coreboot.org/c/coreboot/+/40334/2//COMMIT_MSG@10 PS2, Line 10: It can boot SonoraPass EVT board w/ ES1 CPX-SP and ES PCH. Due to IRQs issue, it has yet to boot into Linuxboot/u-root payload.
The maximum is actually 72
Done
https://review.coreboot.org/c/coreboot/+/40334/2//COMMIT_MSG@12 PS2, Line 12: Change-Id: I60452205d666fd19582780401ccd9d7773e68a5b
please add Signed-off-by line in commit message
Done