Attention is currently required from: Henry Sun, Paul Menzel, Tao Xia.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55035 )
Change subject: mb/google/dedede/var/sasukette: Modify the touch pad slave address
......................................................................
Patch Set 3: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55035/comment/961da5a3_1f38cf7a
PS3, Line 7: slave
Nit: slave -> I2C just as an effort to use inclusive language.
https://review.coreboot.org/c/coreboot/+/55035/comment/5a97c672_4470b78c
PS3, Line 9: slave
Same comment as above.
https://review.coreboot.org/c/coreboot/+/55035/comment/eb08b0c5_a5dc2407
PS3, Line 10:
Nit: remove extra space at the end of the line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0bd80baa27dfeb7bcb43f0ca4b02e1228e372a6
Gerrit-Change-Number: 55035
Gerrit-PatchSet: 3
Gerrit-Owner: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-CC: Jessie Xu
xuyanan@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Tue, 01 Jun 2021 16:24:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment