Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33824 )
Change subject: mainboard/google/hatch: create akemi variant. ......................................................................
Patch Set 7:
(5 comments)
https://review.coreboot.org/c/coreboot/+/33824/7/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/33824/7/src/mainboard/google/hatch/... PS7, Line 39: config CHROMEOS_WIFI_SAR : bool "Enable SAR options for Chrome OS build" : depends on CHROMEOS : select DSAR_ENABLE : select GEO_SAR_ENABLE : select SAR_ENABLE : select USE_SAR : select WIFI_SAR_CBFS : This already merged here: https://review.coreboot.org/c/coreboot/+/34580. You need to sync your repo and rebase.
https://review.coreboot.org/c/coreboot/+/33824/7/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/33824/7/src/mainboard/google/hatch/... PS7, Line 9: : : : : : This was already removed here: https://review.coreboot.org/c/coreboot/+/34432
https://review.coreboot.org/c/coreboot/+/33824/7/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/gpio.c:
https://review.coreboot.org/c/coreboot/+/33824/7/src/mainboard/google/hatch/... PS7, Line 22: gpio_table I haven't looked at the schematics. I will let Philip/Marco confirm this looks good.
https://review.coreboot.org/c/coreboot/+/33824/7/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
PS7: Is this file a copy of hatch? If yes, the devices added to i2c and spi buses should probably be removed then. +Philip, +Marco.
https://review.coreboot.org/c/coreboot/+/33824/7/src/mainboard/google/hatch/... PS7, Line 41: .rise_time_ns = 60, : .fall_time_ns = 25, : }, Are these really valid?