5 comments:
File src/mainboard/google/hatch/Kconfig:
config CHROMEOS_WIFI_SAR
bool "Enable SAR options for Chrome OS build"
depends on CHROMEOS
select DSAR_ENABLE
select GEO_SAR_ENABLE
select SAR_ENABLE
select USE_SAR
select WIFI_SAR_CBFS
This already merged here: https://review.coreboot.org/c/coreboot/+/34580. You need to sync your repo and rebase.
File src/mainboard/google/hatch/Kconfig.name:
This was already removed here: https://review.coreboot.org/c/coreboot/+/34432
File src/mainboard/google/hatch/variants/akemi/gpio.c:
Patch Set #7, Line 22: gpio_table
I haven't looked at the schematics. I will let Philip/Marco confirm this looks good.
File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
Is this file a copy of hatch? If yes, the devices added to i2c and spi buses should probably be removed then. +Philip, +Marco.
.rise_time_ns = 60,
.fall_time_ns = 25,
},
Are these really valid?
To view, visit change 33824. To unsubscribe, or for help writing mail filters, visit settings.