build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40701 )
Change subject: device: Constify struct device * parameter to write_acpi_tables ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40701/1/src/soc/intel/skylake/inclu... File src/soc/intel/skylake/include/soc/acpi.h:
https://review.coreboot.org/c/coreboot/+/40701/1/src/soc/intel/skylake/inclu... PS1, Line 22: unsigned long northbridge_write_acpi_tables(const struct device *, function definition argument 'const struct device *' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40701/1/src/soc/intel/skylake/inclu... PS1, Line 22: unsigned long northbridge_write_acpi_tables(const struct device *, function definition argument 'struct acpi_rsdp *' should also have an identifier name