Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34710 )
Change subject: soc/intel/{cnl,icl}: Add provision to use PIRX PCI IRQ acpi package
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34710/4/src/soc/intel/icelake/acpi/...
File src/soc/intel/icelake/acpi/pci_irqs.asl:
https://review.coreboot.org/c/coreboot/+/34710/4/src/soc/intel/icelake/acpi/...
PS4, Line 25: External(PIRX)
So if you change the scope to _SB.PCI0, I think this declaration needs to include that as well.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34710
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib23e57d3ce58406f8faff18e912b78a911e50d3d
Gerrit-Change-Number: 34710
Gerrit-PatchSet: 4
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 02 Oct 2019 19:40:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment