Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39285 )
Change subject: mb/google/dedede Add Audio support for waddledoo ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... PS8, Line 101: PLTRST
How does this behave with S3? Does it result in any unwanted issues on resume in OS? I know S3 is no […]
Not tested with S3 Furquan, but since it is set for PLTRST , it would go back to default on PLTRST assertion and configured back in ramstage for boot beep and kernel usage
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39285/8/src/mainboard/google/dedede... PS8, Line 41: .scl_lcnt = 176, : .scl_hcnt = 95, : .sda_hold = 36,
We might need some more tuning to bring this close to 400. […]
Ok, raised a bug #151302522 to track tuning