Attention is currently required from: Eric Lai.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81824?usp=email )
Change subject: include: Add 'IWYU pragma: export' comment
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
I can add /* IWYU pragma: export */ for both lines and keep same order if you want
File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/81824/comment/6f29dfee_cbd0fb16 :
PS2, Line 12: #include <device/pci_type.h>
why change the order?
to move <device/pci_type.h> out of "WYU pragma: begin/end export"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81824?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3acb5e6b18443e454d8174b0b1f9d207c0fb78b5
Gerrit-Change-Number: 81824
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
ericllai@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Comment-Date: Fri, 12 Apr 2024 09:30:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Gerrit-MessageType: comment