Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46930 )
Change subject: soc/mediatek/common: A common API for loading the blob file
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46930/14/src/soc/mediatek/common/mt...
File src/soc/mediatek/common/mtlib.c:
https://review.coreboot.org/c/coreboot/+/46930/14/src/soc/mediatek/common/mt...
PS14, Line 25: memcpy((void *)addr, blob_data, blob_bytes);
Yes
CBFS: Found 'dpm.dm' @0x1d980 size 0x1a
load_blob_file: Load dpm.dm in 13 msecs, size 40 bytes
CBFS: Found 'dpm.pm' @0x1da00 size 0x1f8d
read SPI 0x41fa38 0x1f8d: 892 us, 9054 KB/s, 72.432 Mbps
lzma: Decoding error = 1
I encounter this error when feeding SRAM address to cbfs_boot_load_file with larger size.
I will reuse dram_dma region as CBFS buffer for now (assume that all blobs are loaded after DRAM is ready.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46930
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie94001bbda25fe015f43172e92a1006e059de223
Gerrit-Change-Number: 46930
Gerrit-PatchSet: 14
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Roger Lu
roger.lu@mediatek.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 23 Nov 2020 08:05:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Yidi Lin
yidi.lin@mediatek.com
Gerrit-MessageType: comment