Attention is currently required from: Andy Pont, Angel Pons, Andrey Petrov, Patrick Rudolph, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61195 )
Change subject: soc/apollolake: Make IO decode / enable register configurable
......................................................................
Patch Set 4:
(2 comments)
File src/soc/intel/apollolake/bootblock/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139774):
https://review.coreboot.org/c/coreboot/+/61195/comment/811b6b52_6609358c
PS4, Line 78: uint16_t io_enables = LPC_IOE_SUPERIO_2E_2F | LPC_IOE_KBC_60_64 |
'SUPERIO' may be misspelled - perhaps ''?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-139774):
https://review.coreboot.org/c/coreboot/+/61195/comment/42e9cf64_6b1e0d78
PS4, Line 95: LPC_IOE_SUPERIO_2E_2F | LPC_IOE_EC_4E_4F;
'SUPERIO' may be misspelled - perhaps ''?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61195
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I598baca0f31b5350a4e6fdb7b7356fa6fb2d71ed
Gerrit-Change-Number: 61195
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 02 Feb 2022 16:36:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment