Nicolas Boichat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49113 )
Change subject: ec/google/chromeec: Check AP reset cause for watchdog reset ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/49113/1/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/49113/1/src/ec/google/chromeec/ec.c... PS1, Line 1006: resp.ap_resets_since_ec_boot Given this comment here: https://chromium.googlesource.com/chromiumos/platform/ec/+/main/include/ec_c...
I wonder if it's safer to loop in the resp.recent_ap_reset array from the end and find the last entry that is non-zero.
https://review.coreboot.org/c/coreboot/+/49113/1/src/ec/google/chromeec/ec_c... File src/ec/google/chromeec/ec_commands.h:
PS1: Not sure what's the convention in coreboot, but I feel this belongs in a separate CL ("sync ec_commands.h with EC sources at commit xyz")