Attention is currently required from: Karthik Ramasubramanian, Paul Menzel, Subrata Banik.
Ashish Kumar Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81437?usp=email )
Change subject: lib/spd_bin: Add LPDDR5X dram_type in use_ddr4_params
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81437/comment/8f121b73_ea56dc68 :
PS2, Line 9: For dram_type 21 the switch case in use_ddr4_params
: function falls to default. This adds SPD_DRAM_LPDDR5X dram_type
: case to switch case block for dram_type 21 in the function.
Please use 72 characters per line (besides pasted lines). […]
Done
https://review.coreboot.org/c/coreboot/+/81437/comment/d2f7e32f_3632e719 :
PS2, Line 13: Bug
nit: BUG
No bug id available.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81437?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id78ef90c0dc2e869c1f0424674b982ba64ba3939
Gerrit-Change-Number: 81437
Gerrit-PatchSet: 2
Gerrit-Owner: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 26 Mar 2024 09:48:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment