Attention is currently required from: Patrick Georgi, Evgeny Zinoviev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38770 )
Change subject: Documentation: Add MacBook internal flashing tutorial ......................................................................
Patch Set 4: Code-Review+1
(11 comments)
File Documentation/flash_tutorial/int_macbook.md:
https://review.coreboot.org/c/coreboot/+/38770/comment/417b14f8_acd75a8c PS4, Line 24: . Please be more specific:
... using the Flash Descriptor's region protection parameters.
https://review.coreboot.org/c/coreboot/+/38770/comment/407beed3_563e99a2 PS4, Line 26: 4KB nit: 4 KiB
https://review.coreboot.org/c/coreboot/+/38770/comment/c3c35598_ecd85e41 PS4, Line 59: ME firmware nit: the ME firmware
https://review.coreboot.org/c/coreboot/+/38770/comment/82a8ca72_171a206f PS4, Line 90: MB MiB
https://review.coreboot.org/c/coreboot/+/38770/comment/9c2c73cb_6081b00c PS4, Line 123: neutered `me-cleaned` would be more accurate
https://review.coreboot.org/c/coreboot/+/38770/comment/b2f7b280_d499ed91 PS4, Line 189: For now, it's recommended : to use GRUB2. Why?
https://review.coreboot.org/c/coreboot/+/38770/comment/3a13a0da_73d9bb8e PS4, Line 191: needs a patch Where is this patch?
https://review.coreboot.org/c/coreboot/+/38770/comment/692f0111_a43dc17a PS4, Line 195: KB KiB
https://review.coreboot.org/c/coreboot/+/38770/comment/fbbf52a1_4ca52c4c PS4, Line 197: MB MiB
https://review.coreboot.org/c/coreboot/+/38770/comment/6d2ef48d_f704b00d PS4, Line 221: MB MiB
https://review.coreboot.org/c/coreboot/+/38770/comment/9d05d8ed_a7e3243c PS4, Line 248: MB MiB