Attention is currently required from: Raul Rangel, Jon Murphy, Mark Hasemeyer.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74105 )
Change subject: mb/google/myst: Enable USB controllers
......................................................................
Patch Set 25:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74105/comment/8954ea5b_68e6e623
PS25, Line 7: USB
Nit: XHCI
File src/mainboard/google/myst/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/74105/comment/2b6a4283_fedcfad2
PS25, Line 14: device ref xhci_1 on end
How about the ports under gpp_bridge_c?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74105
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I05dc5bb157f0ef955e4b37e34d7b32678e42ebc8
Gerrit-Change-Number: 74105
Gerrit-PatchSet: 25
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Mon, 10 Apr 2023 22:14:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment