Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47055 )
Change subject: [RFC] mb/ocp/deltalake: append Linuxboot command line option ......................................................................
Patch Set 3:
(1 comment)
vpd has to update the coreboot image via cbfs, so it might make more sense to script or add the option to cbfstool to update the payload string.
I understand that vpd RO and RW are handy for the ocp solutions, but aren't implemented in other places, so a more general call to update the string might be more appropriate.
https://review.coreboot.org/c/coreboot/+/47055/3/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/47055/3/src/mainboard/ocp/deltalake... PS3, Line 324: void platform_segment_loaded(uintptr_t start, size_t size, int flags) You probably don't need to call on every segment loaded. Can this be addressed just before the payload is called? I think that arch_bootstate_coreboot_exit() might be the correct call.